Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7624 - Subcategories front-end styling for mobile #7761

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Conversation

fessehaye
Copy link
Contributor

Includes front end stylings for mobile
Closes #7624
Related PRs/issues #7746

You do need to create subcategories on the test site via the admin account in order to test

Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile

Desktop (narrow viewports)

  • the subcategories get cut off on some narrower viewports
  • not able to scroll sideways on desktop narrow viewports
    BmONFDqCkG

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-djujny November 4, 2021 06:04 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 06:04 Inactive
@fessehaye fessehaye changed the base branch from pni-q3-2021 to main November 4, 2021 06:04
@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 07:59 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 17:09 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing

image

Hide Scrollbar?
The scrolling works now but a big scroll appears now on...
narrow viewports:
image
and mobile:
https://user-images.githubusercontent.com/2492510/140402658-16ef9d7f-92e8-4c36-992d-8375ec652abe.mp4

  • Is it possible to hide it while keeping the side scroll functionality?
  • on narrow viewports, is it possible for the subcategories to extend to the edge of the page instead of being cut off at the container?

Thanks for fixing the keyboard trigger issue on mobile, it works way better!

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 20:23 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 20:59 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 21:12 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 22:41 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 4, 2021 23:19 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 5, 2021 00:52 Inactive
Fixed creepyface

fix

subcategories should take full width

oops

done
@mofodevops mofodevops temporarily deployed to foundation-s-7624-mobil-rc8v6l November 5, 2021 01:03 Inactive
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This PR introduces visual differences. Click here to inspect the diffs.

Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the cut off issue and hiding the scrollbar! 👍

I'll file a separate QA to be able to drag to scroll the subcategories to improve usability

@sabrinang
Copy link

I filed the QA drag to scroll issue here: #7787

Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Simon! Thanks for tagging me on this:

I took a look at the code and everything looks good to me, I did find one minor thing however I am not sure if it is by design:

At the medium breakpoint the subcategories seem to get unaligned with the large category at the top:
image

If this is to be expected, please let me know and I will approve the changes, thanks!

Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Simon! Thanks for answering my questions, approved!

@fessehaye fessehaye merged commit a074262 into main Nov 5, 2021
@fessehaye fessehaye deleted the 7624-mobile branch November 5, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PNI] - Subcategories -[PNI] - Subcategories - front-end styling for mobile
5 participants