Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

[Pico] Cannot send url when launch browser activity if FxR is not running #3431

Closed
picoxr opened this issue May 28, 2020 · 4 comments · Fixed by #3443
Closed

[Pico] Cannot send url when launch browser activity if FxR is not running #3431

picoxr opened this issue May 28, 2020 · 4 comments · Fixed by #3443
Assignees
@bluemarvin
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone
#11 polish

Comments

@picoxr
Copy link

picoxr commented May 28, 2020 •
edited
Loading

Configuration

Firefox Reality version: 10-rc7
Firefox Reality build ID: bda5ecf

Hardware: Pico Neo2 - Android 8.1.0 - PUI 3.11.3

Steps to Reproduce

  1. Kill Firefox Reality application to make sure it's not running on background
  2. Use adb command: adb shell am start -a android.intent.action.VIEW -d "https://aframe.io/" org.mozilla.vrbrowser/org.mozilla.vrbrowser.VRBrowserActivity to launch Firefox Reality and send url meanwhile
  3. Observe the behavior.

Current Behavior

Firefox Reality launches with success but it couldn't direct to the url specified in adb command

Expected Behavior

Firefox Reality launches and direct to the specified url meanwhile.

Possible Solution

Context

  1. The use case is to open up a link in Firefox Reality from another app.
  2. Oculus version seems to behave the same way.
  3. Url can be sent correctly if FxR is running on background.

Error Logs and Stack Traces
@bluemarvin bluemarvin self-assigned this May 30, 2020
bluemarvin added a commit that referenced this issue May 30, 2020
@bluemarvin
Wait to load URI from intent until after session restore.
32ddef2 
Fixes #3431

This patch changes the behavior of launching or opening a URI
from an intent. Previously the URI would be opened in the focuses window.
With this patch it matches Fenix and desktop and creates a new tab in the
focused window.
@bluemarvin bluemarvin mentioned this issue May 30, 2020
Merged
@bluemarvin
Copy link
Contributor

Regressed by #3364

@bluemarvin bluemarvin added this to the #11 polish milestone May 30, 2020
bluemarvin added a commit that referenced this issue Jun 1, 2020
@bluemarvin
Wait to load URI from intent until after session restore.
d398ae5 
Fixes #3431

This patch changes the behavior of launching or opening a URI
from an intent. Previously the URI would be opened in the focuses window.
With this patch it matches Fenix and desktop and creates a new tab in the
focused window.
bluemarvin added a commit that referenced this issue Jun 1, 2020
@bluemarvin
Wait to load URI from intent until after session restore.
2ebd367 
Fixes #3431

This patch changes the behavior of launching or opening a URI
from an intent. Previously the URI would be opened in the focuses window.
With this patch it matches Fenix and desktop and creates a new tab in the
focused window.
bluemarvin added a commit that referenced this issue Jun 2, 2020
@bluemarvin
Wait to load URI from intent until after session restore.
e817e1b 
Fixes #3431

This patch changes the behavior of launching or opening a URI
from an intent. Previously the URI would be opened in the focuses window.
With this patch it matches Fenix and desktop and creates a new tab in the
focused window.
keianhzo pushed a commit that referenced this issue Jun 3, 2020
@bluemarvin
Wait to load URI from intent until after session restore. (#3443)
38cba1e 
Fixes #3431

This patch changes the behavior of launching or opening a URI
from an intent. Previously the URI would be opened in the focuses window.
With this patch it matches Fenix and desktop and creates a new tab in the
focused window.
@Softvision-GeluHaiduc
Copy link

I have verified this issue with the latest Firefox Reality version 11-141551002 (8f4de9a) installed on the Oculus Go, Oculus Quest, HTC Vive Focus, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
When using a Pico or Oculus device the URL can be sent while FxR is not running.
When using a HTC device the device remains stuck on the vive loading screen and can not be force-killed using an adb command, the only way to exit this loading screen is by pressing the Vive button for more than 20 sec. or by restarting the device.
The adb command to open the URL works as expected if FxR is opened.

@bluemarvin Should I open a different issue for the HTC devices?

@bluemarvin
Copy link
Contributor

@Softvision-GeluHaiduc I'm not able to reproduce this issue. When I run the following on the Focus Plus:

adb shell am force-stop org.mozilla.vrbrowser.internal
adb shell am start -a android.intent.action.VIEW -d "youtube.com" org.mozilla.vrbrowser.internal/org.mozilla.vrbrowser.VRBrowserActivity

FxR launches and then opens the specified URL.

@Softvision-GeluHaiduc
Copy link

I was using this command
adb shell am start -a android.intent.action.VIEW -d https://www.youtube.com/ -t application/browser -n org.mozilla.vrbrowser.internal/org.mozilla.vrbrowser.VRBrowserActivity

Using the command from the above comment the issue is not reproducing.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bluemarvin bluemarvin

Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Milestone
#11 polish
Development

Successfully merging a pull request may close this issue.

Wait to load URI from intent until after session restore. MozillaReality/FirefoxReality
3 participants
@bluemarvin @picoxr @Softvision-GeluHaiduc