Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix Database crash between v10 versions #3345

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix Database crash between v10 versions #3345

merged 1 commit into from
May 8, 2020

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro MortimerGoro added this to the #10 features milestone May 7, 2020
@MortimerGoro MortimerGoro self-assigned this May 7, 2020
keianhzo
keianhzo approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested updates:

  • v10-p2 -> v10: No crashes, DB entries are lost but it's expected
  • v9-rc10 -> v10: No crashes and DB entries are kept.

So LGTM

@bluemarvin bluemarvin merged commit fb0babb into master May 8, 2020
@bluemarvin bluemarvin deleted the v10/pico_fix_database branch May 8, 2020 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@keianhzo keianhzo keianhzo approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
#10 features
Development

Successfully merging this pull request may close these issues.
3 participants
@MortimerGoro @bluemarvin @keianhzo