Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make many things @internal #668

Open
oliverklee opened this issue Aug 25, 2024 · 0 comments
Open

Make many things @internal #668

oliverklee opened this issue Aug 25, 2024 · 0 comments
Assignees
@oliverklee
Milestone
8.6.1 or 8.7.0

Comments

@oliverklee
Copy link
Contributor

We want to able to refactor internal things without being afraid of breaking things.

Probably all within Parsing.
@oliverklee oliverklee added this to the 8.6.1 or 8.7.0 milestone Aug 25, 2024
@oliverklee oliverklee self-assigned this Aug 26, 2024
oliverklee added a commit that referenced this issue Aug 26, 2024
@oliverklee
[TASK] Mark parsing-internal classes and methods as @internal
58b9182 
Code that uses this library is not expected to call internal parsing
functionality. Communicate this with the corresponding `@internal`
annotation.

This allows us to boldly refactor the parser code.

Part of #668
@oliverklee oliverklee mentioned this issue Aug 26, 2024
Merged
oliverklee added a commit that referenced this issue Aug 28, 2024
@oliverklee
[TASK] Mark parsing-internal classes and methods as @internal
748a15c 
Code that uses this library is not expected to call internal parsing
functionality. Communicate this with the corresponding `@internal`
annotation.

This allows us to boldly refactor the parser code.

Part of #668
oliverklee added a commit that referenced this issue Sep 5, 2024
@oliverklee
[TASK] Mark parsing-internal classes and methods as @internal
c7316cf 
Code that uses this library is not expected to call internal parsing
functionality. Communicate this with the corresponding `@internal`
annotation.

This allows us to boldly refactor the parser code.

Part of #668
oliverklee added a commit that referenced this issue Sep 5, 2024
@oliverklee
[TASK] Mark parsing-internal classes and methods as @internal (#674)
707b5cb 
Code that uses this library is not expected to call internal parsing
functionality. Communicate this with the corresponding `@internal`
annotation.

This allows us to boldly refactor the parser code.

Part of #668
oliverklee added a commit that referenced this issue Sep 5, 2024
@oliverklee
[TASK] Mark parsing-internal classes and methods as @internal
108bd8f 
Code that uses this library is not expected to call internal parsing
functionality. Communicate this with the corresponding `@internal`
annotation.

This allows us to boldly refactor the parser code.

This is the backport of #674.

Part of #668
@oliverklee oliverklee mentioned this issue Sep 5, 2024
Merged
JakeQZ pushed a commit that referenced this issue Sep 5, 2024
@oliverklee
[TASK] Mark parsing-internal classes and methods as @internal (#711)
d6a4b2a 
Code that uses this library is not expected to call internal parsing
functionality. Communicate this with the corresponding `@internal`
annotation.

This allows us to boldly refactor the parser code.

This is the backport of #674.

Part of #668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
8.6.1 or 8.7.0
Development

No branches or pull requests
1 participant
@oliverklee