[CLEANUP] Remove an impossible throw
#1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the basis of this, and a few other things, PHPStan impresses me much. It keeps me warm in the middle of the night. I wonder if Shania Twain agrees. |
|
@JakeQZ And it warms my heart to see you so motivated by increasing code coverage and killing PHPStan warnings! ❤️ (It's the same for me. I find PHPStan quite addictive.) |
PHPStan is able to determine that `array_combine` when passed the results of `array_keys` and `array_values` for the same array can never fail (in the sense of returning `false`), because the two passed arrays will always be the same length. Psalm could not, which was why the return value check and `throw` was originally put in.
oliverklee
force-pushed
the
cleanup/remove-impossible-throw
branch
from
3bc3d6a
to
5dcdd64
Compare
oliverklee
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan is able to determine that
array_combinewhen passed the results ofarray_keysandarray_valuesfor the same array can never fail (in the sense of returningfalse), because the two passed arrays will always be the same length.Psalm could not, which was why the return value check and
throwwas originally put in.