Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:breadcrumb): remove redundant dom nodes #8017

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jul 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The nz-breadcrumb-separator has extra dom nodes.

image

Issue Number: N/A

What is the new behavior?

Remove redundant dom nodes in nz-breadcrumb-separator.

image

Does this PR introduce a breaking change?

[x] Yes
[ ] No

This may break user custom styles, which may be rare:

nz-breadcrumb-separator .ant-breadcrumb-separator { }
nz-breadcrumb-separator > .ant-breadcrumb-separator { }
nz-breadcrumb-separator span { }
nz-breadcrumb-separator > span { }

Other information

This commit also fixes the documentation and simplifies some code.

@zorro-bot
Copy link

zorro-bot bot commented Jul 16, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #8017 (b0577f0) into master (2d0b3f7) will not change coverage.
The diff coverage is n/a.

❗ Current head b0577f0 differs from pull request most recent head 6859d88. Consider uploading reports for the commit 6859d88 to get more accurate results

@@           Coverage Diff           @@
##           master    #8017   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         515      515           
  Lines       17637    17637           
  Branches     2789     2789           
=======================================
  Hits        16164    16164           
  Misses       1175     1175           
  Partials      298      298           
Impacted Files Coverage Δ
components/breadcrumb/breadcrumb-item.component.ts 100.00% <ø> (ø)
...nents/breadcrumb/breadcrumb-separator.component.ts 100.00% <ø> (ø)

@HyperLife1119 HyperLife1119 force-pushed the fix/breadcrumb branch 2 times, most recently from 39b30ce to 418f645 Compare July 16, 2023 12:22
@HyperLife1119
Copy link
Collaborator Author

HyperLife1119 commented Jul 16, 2023

The PR needs a reviewer. @simplejason

@simplejason simplejason merged commit 24bc5e9 into NG-ZORRO:master Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants