-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for fill_last_batch
parameter to match the real behavior
#1479
Conversation
fixed `fill_last_batch` doc to match the real behavior
fixed `fill_last_batch` doc to match the real behavior
fixed `fill_last_batch` doc to match the real behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is still not fully accurate. There is also a last_batch_padded
in the iterator and pad_last_batch
from the reader which combined together impacts the overall behaviour. You can check the table with an example at the end of the function docstring you have updated.
would changing
to
make it more accurate? I do understand that a combination of these 3 parameters may produce unexpected behavior but I think that it's enough to say what one parameter changes and everything else is explained in the table at the end of the docstring |
I agree with the new wording. Please adjust accordingly. |
@bonlime - can you add a sign-off to your commit so we can merge it? |
Signed-off-by: Emil Zakirov <bonlimezak@gmail.com>
…o bonlime-patch-1 Signed-off-by: Emil Zakirov <bonlimezak@gmail.com>
Signed-off-by: Emil Zakirov <bonlimezak@gmail.com>
…o bonlime-patch-1
Okay. I have to admit I don't know how to sign previous commits :c |
That is enough. Thanks for the contribution! |
Why we need this PR?
What happened in this PR?
Fixed
fill_last_batch
parameter docstring to match the real behavior