-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template #3129
Update PR template #3129
Conversation
6a4fa1f
to
bfc771e
Compare
.github/PULL_REQUEST_TEMPLATE.md
Outdated
- [ ] Implements new requirements | ||
- [ ] N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ] Implements new requirements | |
- [ ] N/A | |
- [ ] Implements new requirements | |
- [ ] Affects existing requirements | |
- [ ] N/A |
bfc771e
to
40f7b83
Compare
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
||
- [ ] Existing documentation apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ] Existing documentation apply | |
- [ ] Existing documentation applies |
However, it would be nice to have some more boxes (Docstrings, Doxygen, RST, Ohter).
.github/PULL_REQUEST_TEMPLATE.md
Outdated
- [ ] Existing tests apply | ||
- [ ] New tests added | ||
- [ ] N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python tests / GTest / Benchmark?
If we have checkboxes it seems cheap to add them.
ded5f9c
to
c976281
Compare
Signed-off-by: Joaquin Anton <janton@nvidia.com>
c976281
to
ea3a1f3
Compare
In my opinion:
Is the most awkward and annoying part for me for a long time. If you leave the The checklist is fine, but I think it should have some explanation for the external contributors. Especially the requirements stuff and JIRA task, maybe it should be moved to some DALI Team only section? |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Description
Describe in detail what happened in this PR
Fill extra details, if applicable
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A