Adjust test scripts and section header for webadataset notebook #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
!build |
jantonguirao
approved these changes
Jul 19, 2021
|
CI MESSAGE: [2610399]: BUILD STARTED |
|
CI MESSAGE: [2610804]: BUILD STARTED |
|
CI MESSAGE: [2610399]: BUILD PASSED |
barci2
approved these changes
Jul 19, 2021
mzient
reviewed
Jul 19, 2021
| "metadata": {}, | ||
| "source": [ | ||
| "## Introduction\n", | ||
| "### Data Representation\n", | ||
| "Web Dataset is a dataset representation that heavily optimizes networked accessed storage performance. At its simplest, it stores the whole dataset in one tarball file, where individual samples are kept under the files with the same names but different extensions. This approach improves drive access caching on the RAM, since the data is represented sequentially.\n", | ||
| "Web Dataset is a dataset representation that heavily optimizes networked accessed storage performance. At its simplest, it stores the whole dataset in one tarball file, where individual samples are kept under the files with the same names but different extensions. This approach improves drive access caching on the RAM, since the data is represented sequentially." |
There was a problem hiding this comment.
Note being very well versed in WebDataset, I find this a bit unclear. Does it mean this?
Suggested change
| "Web Dataset is a dataset representation that heavily optimizes networked accessed storage performance. At its simplest, it stores the whole dataset in one tarball file, where individual samples are kept under the files with the same names but different extensions. This approach improves drive access caching on the RAM, since the data is represented sequentially." | |
| "Web Dataset is a dataset representation that heavily optimizes networked accessed storage performance. At its simplest, it stores the whole dataset in one tarball file, where each sample is represented by one or more entries with the same same name but different extensions. This approach improves drive access caching in RAM, since the data is represented sequentially." |
|
CI MESSAGE: [2610804]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Description
What happened in this PR
Fix CI scripts.
Move
### Shardingsection header in the notebookto separate cell as it didn't render correctly
in the docs.
Additional information
CI scripts
Docs
Dependencies in CI scripts?
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A