Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TF graph-mode test ultra fast #3204

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Jul 30, 2021

Signed-off-by: Krzysztof Lecki klecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

It seems that with every test in graph mode
the default graph is growing and takes longer
and longer to execute. We just clear the default
graph before running the tests and now the
whole test_dali_tf_dataset_graph executes orders
of magnitude faster, almost matching the eager
mode tests.

Additional information

  • Affected modules and functionalities:
    TF tests

  • Key points relevant for the review:
    N/A

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

It seems that with every test in graph mode
the default graph is growing and takes longer
and longer to execute. We just clear the default
graph before running the tests and now the
whole test_dali_tf_dataset_graph executes orders
of magnitude faster, almost matching the eager
mode tests.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Jul 30, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2670013]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2670039]: BUILD STARTED

@klecki klecki changed the title Make graph-mode test ultra fast Make TF graph-mode test ultra fast Jul 30, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2670039]: BUILD PASSED

@JanuszL JanuszL self-assigned this Jul 30, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2670013]: BUILD PASSED

@klecki klecki merged commit db01018 into NVIDIA:main Jul 30, 2021
@JanuszL JanuszL added the important-fix Fixes an important issue in the software or development environment. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants