Build custom libtar in conda #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [2701580]: BUILD STARTED |
|
CI MESSAGE: [2701580]: BUILD FAILED |
- build custom libtar to include the latest patches on top of 1.2.20, including one fixing reading of empty archives Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_libtar_conda
branch
from
87ad888
to
f1e27c8
Compare
|
CI MESSAGE: [2701812]: BUILD STARTED |
klecki
reviewed
Aug 5, 2021
| @@ -0,0 +1,52 @@ | |||
| {% set name = "dali-libtar" %} | |||
There was a problem hiding this comment.
Add license? We have it in yml for ffmpeg
There was a problem hiding this comment.
Or is this copied from conda?
There was a problem hiding this comment.
There was a problem hiding this comment.
How about their license? Do we need any Acknowledgments?
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_libtar_conda
branch
from
6285415
to
b22f91d
Compare
JanuszL
commented
Aug 5, 2021
| @@ -93,7 +93,6 @@ requirements: | |||
| - lmdb >=0.9.28 | |||
| - libtiff >=4.3.0 | |||
| - libsndfile >=1.0.31 | |||
| - libtar >=1.2.20 | |||
There was a problem hiding this comment.
libtar provides a static variant and we link with it so we don't need that in runtime.
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
klecki
approved these changes
Aug 5, 2021
|
CI MESSAGE: [2701812]: BUILD FAILED |
|
CI MESSAGE: [2702190]: BUILD STARTED |
|
CI MESSAGE: [2702198]: BUILD STARTED |
awolant
approved these changes
Aug 5, 2021
|
CI MESSAGE: [2702198]: BUILD PASSED |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.2.20, including one fixing reading of empty archives
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Description
What happened in this PR
Additional information
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A