Remove excessive synchronization in AsyncPool. #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
commented
Aug 17, 2021
| @@ -131,13 +131,13 @@ class cuda_vm_resource_base : public memory_resource<memory_kind::device> { | |||
| stat_ = {}; | |||
| } | |||
|
|
|||
| protected: | |||
| bool defer_dealloc_ = false; | |||
| constexpr bool deferred_dealloc_enabled() const noexcept { return defer_dealloc_; } | |||
There was a problem hiding this comment.
This needs to be public
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [2783263]: BUILD STARTED |
jantonguirao
approved these changes
Aug 17, 2021
awolant
approved these changes
Aug 17, 2021
synchronization |
mzient
changed the title
|
CI MESSAGE: [2783263]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Description
What happened in this PR
Removed excessive syncrhonization when deallocating in async_pool - it effectively injected additional syncrhonization. This defeated deferred deallocation and introduced double syncrhonization when there was no deferred deallocation enabled.
The total time taken by pool tests went down by almost 20%.
Additional information
Affected modules and functionalities:
Key points relevant for the review:
N/A
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A