Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing sizeof in Tensor Test #3267

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Aug 20, 2021

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Take size of element into account when
doing copies and comparisons.

Fixes #3265

Additional information

  • Affected modules and functionalities:
    Tensor Test

  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Take size of elment into account when
doing copies and comparisons.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Aug 20, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2807321]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2807321]: BUILD PASSED

@mzient mzient self-assigned this Aug 22, 2021
@klecki klecki merged commit 32baf98 into NVIDIA:main Aug 23, 2021
@JanuszL JanuszL added the important-fix Fixes an important issue in the software or development environment. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a bug in test code dali/pipeline/data/tensor_test.cc
5 participants