Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access to underlying contiguous TL buffer in Constant op #3276

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Aug 23, 2021

Signed-off-by: Krzysztof Lecki klecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Remove access to underlying contiguous buffer
of TensorList in Constant op.

Instead of log copies over the contiguous buffer,
we do H2D copy or fill of the first sample and than
repeat it in the rest.

Additional information

  • Affected modules and functionalities:
    Constant op

  • Key points relevant for the review:
    N/A

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Aug 23, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2823918]: BUILD FAILED

@klecki
Copy link
Contributor Author

klecki commented Aug 23, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2824107]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2824107]: BUILD FAILED

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Aug 23, 2021

!build

@mzient mzient self-assigned this Aug 23, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2824423]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2824423]: BUILD PASSED

@klecki klecki changed the title Remove access to underlying contiguous buffer in Constant op Remove access to underlying contiguous TL buffer in Constant op Aug 24, 2021
@klecki klecki merged commit 12212bc into NVIDIA:main Aug 25, 2021
@JanuszL JanuszL mentioned this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants