Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear to_dealloc and notify under a lock. #3282

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Aug 25, 2021

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Clear and notify under a lock - otherwise it's was possible that the list was cleared between the if (!NoPendingDeallocs() and ready_.wait().

Additional information

Deferred deallocation in memory resources.

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2263

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Copy link
Contributor Author

mzient commented Aug 25, 2021

!build

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2837666]: BUILD STARTED

@NVIDIA NVIDIA deleted a comment from dali-automaton Aug 25, 2021
@NVIDIA NVIDIA deleted a comment from dali-automaton Aug 25, 2021
@mzient mzient assigned mzient and unassigned mzient Aug 25, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2837666]: BUILD PASSED

@mzient mzient merged commit d20b7c7 into NVIDIA:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants