Remove access to underlying contiguous TL buffer in bb_flip op #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2841010]: BUILD STARTED |
|
CI MESSAGE: [2841010]: BUILD PASSED |
szalpal
approved these changes
Aug 26, 2021
dali/operators/bbox/bb_flip.cu
Outdated
Comment on lines
75
to
78
| DALI_ENFORCE(IsType<float>(input.type()), | ||
| "Expected input data as float;" | ||
| " got " + | ||
| input.type().name()); |
There was a problem hiding this comment.
Use make_string instead of + on strings.
dali/operators/bbox/bb_flip.cu
Outdated
Comment on lines
81
to
82
| " got " + | ||
| std::to_string(input.size())); |
stiepan
approved these changes
Aug 27, 2021
|
!build |
|
CI MESSAGE: [2856786]: BUILD STARTED |
|
CI MESSAGE: [2856786]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What happened in this PR
Remove access to underlying contiguous TL buffer in bb_flip op
Additional information
Affected modules and functionalities:
BbFlip
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A