Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing condition variable include #3289

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Aug 26, 2021

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Added a missing header to fix compilation on some platforms,
Fixes #3287.

Additional information

  • Affected modules and functionalities:
  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Aug 26, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2848819]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2848819]: BUILD PASSED

@@ -16,9 +16,10 @@
#ifndef DALI_CORE_MM_DETAIL_DEFERRED_DEALLOC_H_
#define DALI_CORE_MM_DETAIL_DEFERRED_DEALLOC_H_

#include <condition_variable>
Copy link
Contributor

@mzient mzient Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's alphabetically sorted, but it seems weird to have sophisticated headers before cstddef... Normally I wouldn't look for cstddef anywhere else than at the very top.

@mzient mzient self-assigned this Aug 27, 2021
@klecki klecki merged commit 7d05116 into NVIDIA:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when building DALI (release_v1.5) for ppc64le
4 participants