Add yaml as a Webdataset test dependency #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [2871757]: BUILD STARTED |
klecki
approved these changes
Aug 30, 2021
banasraf
approved these changes
Aug 30, 2021
|
CI MESSAGE: [2871757]: BUILD FAILED |
|
Apparently it's this: https://pypi.org/project/PyYAML/ instead of just |
- the latest webdataset python package caries silent yaml dependency what break DALI test. This PR adds a missing package to the installation process. - removes a usage of the `shardshuffle` parameters in webdataset example as it is no longer available in webdataset API Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
!build |
klecki
approved these changes
Aug 30, 2021
|
CI MESSAGE: [2872578]: BUILD STARTED |
23 tasks
|
CI MESSAGE: [2872578]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency what break DALI test. This PR adds a missing package
to the installation process.
shardshuffleparameters in shardshuffleexample as it is no longer available in webdataset API
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Description
What happened in this PR
dependency what break DALI test. This PR adds a missing package
to the installation process.
shardshuffleparameters in shardshuffleexample as it is no longer available in webdataset API
Additional information
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A