Adjust usage of rasies and assert_raises in tests #3318
Conversation
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2924536]: BUILD STARTED |
|
CI MESSAGE: [2924536]: BUILD FAILED |
|
CI MESSAGE: [2924536]: BUILD PASSED |
| @@ -29,7 +29,7 @@ def test_keras_single_cpu(): | |||
| run_keras_single_device('cpu', 0) | |||
|
|
|||
|
|
|||
| @raises(Exception) | |||
| @raises(Exception, "TF device and DALI device mismatch. TF*: CPU, DALI*: GPU for output*") | |||
There was a problem hiding this comment.
You don't need to add trailing * at the end of glob pattern.
| batch_size=batch_size, | ||
| output_shapes=shapes, | ||
| output_dtypes=dtypes, | ||
| num_threads=num_threads) | ||
|
|
||
|
|
||
| @raises(RuntimeError) | ||
| @raises(RuntimeError, "*some operators*cannot be used with TensorFlow Dataset API and DALIIterator") |
There was a problem hiding this comment.
Do you need leading * in glob pattern?
|
|
||
| for shape, layout in [([6, 1], "XF"), ([8, 10, 3], "HWC")]: | ||
| with assert_raises(RuntimeError, | ||
| glob="Input layout must describe a sequence*start with 'F', got*instead"): |
There was a problem hiding this comment.
I'm not about this pattern. wildcards inside doesn't provide any flexibility from my point of view, so you can put the whole message here as well.
| check_element_extract(shape, layout, [1, 3], "cpu") | ||
|
|
||
| with assert_raises(RuntimeError, | ||
| glob="Index*10*from *element_map* out of bounds for*sequence length*6*"): |
There was a problem hiding this comment.
I'm not about this pattern. wildcards inside doesn't provide any flexibility from my point of view, so you can put the whole message here as well.
There was a problem hiding this comment.
Now I'm just worried, that we will want to fix the ', ` and " around the variables.
There was a problem hiding this comment.
But then we can adjust the test, it would be easily detectable.
There was a problem hiding this comment.
It is unclear for me what we want to leave undefined and what to be strict about. * just for " or ` blurs the pattern from my point of view.
|
!build |
|
CI MESSAGE: [2931550]: BUILD STARTED |
|
CI MESSAGE: [2931550]: BUILD PASSED |
Description
What happened in this PR
assert_raisesandraisesutilities with glob pattern checked against
the error message.
(cause the expected exception).
Additional information
Affected modules and functionalities:
tests
Key points relevant for the review:
N/A
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2234