Remove access to underlying contiguous TL buffer from tests #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [2937387]: BUILD STARTED |
|
CI MESSAGE: [2937387]: BUILD PASSED |
banasraf
reviewed
Sep 9, 2021
| @@ -35,7 +35,7 @@ void GenerateShapeTestInputs(TensorList<Backend> &out, RNG &rng, int num_samples | |||
| } | |||
| out.Reset(); | |||
| out.Resize(shape); | |||
| (void)out.template mutable_data<uint8_t>(); | |||
| out.set_type(TypeInfo::Create<uint8_t>()); | |||
There was a problem hiding this comment.
Suggested change
| out.set_type(TypeInfo::Create<uint8_t>()); | |
| out.set_type(TypeTable::GetTypeInfoFromStatic<uint8_t>()); |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
rework-tests
branch
from
df0ef7b
to
cc23c10
Compare
banasraf
approved these changes
Sep 10, 2021
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2955620]: BUILD STARTED |
banasraf
approved these changes
Sep 10, 2021
|
CI MESSAGE: [2955620]: BUILD PASSED |
stiepan
reviewed
Sep 13, 2021
| for (size_t n = 0; n < N; n++) { | ||
| tl->Resize(uniform_list_shape(N, {kBbStructSize})); |
There was a problem hiding this comment.
Does this line need to be inside for loop?
There was a problem hiding this comment.
Moved accidentally, fixed.
|
!build |
stiepan
approved these changes
Sep 13, 2021
|
CI MESSAGE: [2971157]: BUILD STARTED |
|
CI MESSAGE: [2971157]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Description
What happened in this PR
Tests access TL on sample basis instead of using underlying contiguous allocation.
Remove some dead code.
Additional information
Affected modules and functionalities:
Tests
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2234