Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeviceBuffer copy - use proper copy function. #3344

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix DeviceBuffer copy - use proper copy function. #3344

merged 1 commit into from
Sep 16, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Sep 15, 2021

Signed-off-by: Michal Zientkiewicz michalz@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Fixes issue #3340 - imcorrect copy function used in DeviceBuffer::copy

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@mzient
Fix DeviceBuffer copy - use proper copy function.
e598b9a 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2987940]: BUILD STARTED

@JanuszL JanuszL self-assigned this Sep 15, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2987940]: BUILD PASSED

@awolant awolant self-assigned this Sep 16, 2021
@mzient mzient merged commit f64d866 into NVIDIA:main Sep 16, 2021
@JanuszL JanuszL modified the milestone: Release_1.7.0 Sep 23, 2021
@JanuszL JanuszL added the important-fix Fixes an important issue in the software or development environment. label Sep 30, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Oct 17, 2021
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
a6be302 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
ffd970d 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
024d78f 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
017e5bc 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
08cfbc4 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
20dd6fd 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
204e0b3 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
89bd76a 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
fce4352 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
a813e23 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
b443a35 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
a846a8d 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
fed11b2 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
cd2af4d 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
21d74b8 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
10f2fe6 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@mzient @cyyever
Fix DeviceBuffer copy - use proper copy function. (NVIDIA#3344)
06c39f7 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@awolant awolant awolant approved these changes

Assignees

@JanuszL JanuszL

@awolant awolant

Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzient @dali-automaton @JanuszL @awolant