Fix and optimize name handling in TypeInfo. #3349

mzient · 2021-09-17T15:05:18Z

Improve name handling in TypeInfo.
Simplify TypeInfo default constructor.
Fix stringification of custom type ids.
Add test for custom name stringification.

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Description

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactoring (Redesign of existing code that doesn't affect functionality)
Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

optimize name stringification by providing a fast path for names of built-in types
provide separate implementations of operator<< and to_string to gain further speedup
get the name of custom types from TypeTable and use it in to_string and operator<< for DALIDataType

Additional information

Affected modules and functionalities:

Key points relevant for the review:

Checklist

Tests

New test: test TypeInfo for a custom type.

Documentation

DALI team only

Requirements

Implements new requirements
Affects existing requirements
N/A

REQ IDs: N/A

JIRA TASK: N/A

* Simplify TypeInfo default constructor. * Fix stringification of custom type ids. * Add test for custom name stringification. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>

dali-automaton · 2021-09-17T15:09:01Z

CI MESSAGE: [3002968]: BUILD STARTED

JanuszL · 2021-09-17T15:50:42Z

dali/pipeline/data/types.h

+  auto *info = TypeTable::TryGetTypeInfo(dtype);
+  if (info)
+    return os << info->name();
+  // Use string concatenation so that the result is the same aas in to_string, unaffected by


Suggested change

// Use string concatenation so that the result is the same aas in to_string, unaffected by

// Use string concatenation so that the result is the same as in to_string, unaffected by

Fixed. I'll report anyone who launches CI for that to EPA ;)

dali-automaton · 2021-09-17T16:28:50Z

CI MESSAGE: [3002968]: BUILD PASSED

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>

* Improve name handling in TypeInfo. * Simplify TypeInfo default constructor. * Fix stringification of custom type ids. * Add test for custom name stringification. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>

* Improve name handling in TypeInfo.

e92daef

* Simplify TypeInfo default constructor. * Fix stringification of custom type ids. * Add test for custom name stringification. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>

JanuszL self-assigned this Sep 17, 2021

JanuszL reviewed Sep 17, 2021

View reviewed changes

JanuszL approved these changes Sep 17, 2021

View reviewed changes

Fix a typo.

46b4a2d

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>

klecki assigned banasraf Sep 20, 2021

banasraf approved these changes Sep 20, 2021

View reviewed changes

mzient merged commit 84060c7 into NVIDIA:main Sep 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and optimize name handling in TypeInfo. #3349

Fix and optimize name handling in TypeInfo. #3349

mzient commented Sep 17, 2021

dali-automaton commented Sep 17, 2021

JanuszL Sep 17, 2021

mzient Sep 18, 2021

dali-automaton commented Sep 17, 2021

	// Use string concatenation so that the result is the same aas in to_string, unaffected by
	// Use string concatenation so that the result is the same as in to_string, unaffected by

Fix and optimize name handling in TypeInfo. #3349

Fix and optimize name handling in TypeInfo. #3349

Conversation

mzient commented Sep 17, 2021

Description

What happened in this PR

Additional information

Checklist

Tests

Documentation

DALI team only

Requirements

dali-automaton commented Sep 17, 2021

JanuszL Sep 17, 2021

Choose a reason for hiding this comment

mzient Sep 18, 2021

Choose a reason for hiding this comment

dali-automaton commented Sep 17, 2021