Remove access to contiguous TL buffer from Coco Reader tests #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [3004698]: BUILD STARTED |
JanuszL
reviewed
Sep 17, 2021
| shape[sample_idx].num_elements() * sizeof(int)); | ||
| out_ptr += shape[sample_idx].num_elements(); | ||
| } | ||
| cudaStreamSynchronize(0); |
There was a problem hiding this comment.
You don't need that. You are using pagable memory in the copy so it syncs by definition.
JanuszL
reviewed
Sep 17, 2021
| boxes_shape[sample_idx].num_elements() * sizeof(float)); | ||
| boxes_ptr += boxes_shape[sample_idx].num_elements(); | ||
| } | ||
| cudaStreamSynchronize(0); |
JanuszL
reviewed
Sep 17, 2021
| labels_shape[sample_idx].num_elements() * sizeof(int)); | ||
| labels_ptr += labels_shape[sample_idx].num_elements(); | ||
| } | ||
| cudaStreamSynchronize(0); |
JanuszL
reviewed
Sep 17, 2021
| vertices_shape[sample_idx].num_elements() * sizeof(float)); | ||
| vertices_ptr += vertices_shape[sample_idx].num_elements(); | ||
| } | ||
| cudaStreamSynchronize(0); |
JanuszL
approved these changes
Sep 17, 2021
|
CI MESSAGE: [3004698]: BUILD PASSED |
stiepan
approved these changes
Sep 20, 2021
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Oct 17, 2021
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Feb 21, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Closed
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What happened in this PR
Remove access to contiguous TL buffer from Coco Reader tests.
Introduce sample-by-sample copies.
Additional information
Affected modules and functionalities:
Coco reader tests
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A