Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general perf changes alongside WDS perf #3363

Merged
merged 2 commits into from
Sep 24, 2021
Merged

general perf changes alongside WDS perf #3363

merged 2 commits into from
Sep 24, 2021

Conversation

barci2
Copy link
Contributor

@barci2 barci2 commented Sep 22, 2021 •
edited
Loading

Signed-off-by: Bartłomiej Cieślar bcieslar2001@gmail.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

  • small refactor in executor
  • changed memory reallocation settings

Additional information

  • Affected modules and functionalities:

Separated from DALI-3360 to cherry-pick it into LWS

  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@barci2
moved requested changes from webdataset_perf_1
27dc8a5 
Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
@JanuszL JanuszL self-assigned this Sep 22, 2021
@JanuszL
Copy link
Contributor

JanuszL commented Sep 22, 2021

I would name the PR as Adjust grow and shrink thresholds for CPU memory and in the description write what is the purpose of it.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3032337]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3032340]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3032340]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3032337]: BUILD FAILED

@barci2
bug fixes
ee93258 
Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3041263]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3041271]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3041263]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3041271]: BUILD PASSED

@barci2 barci2 merged commit b71f07d into NVIDIA:main Sep 24, 2021
@barci2 barci2 mentioned this pull request Sep 28, 2021
Merged
23 tasks
cyyever pushed a commit to cyyever/DALI that referenced this pull request Oct 17, 2021
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
8e23c4d 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
b044267 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
de1496d 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
9b35fb5 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
439b3dd 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
8d18300 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
b4a921f 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
decf55d 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
22a09aa 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
501e3f8 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
fed68e9 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
8b49ee1 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
eded5df 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
a283e3b 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
3406a9b 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
5c46123 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@barci2 @cyyever
general perf changes alongside WDS perf (NVIDIA#3363)
dd4e0c1 
* moved requested changes from webdataset_perf_1

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>

* bug fixes

Signed-off-by: Bartłomiej Cieślar <bcieslar2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzient mzient mzient approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@mzient mzient

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barci2 @JanuszL @dali-automaton @mzient