Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_convergence #3376

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_convergence #3376

merged 1 commit into from
Sep 28, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 27, 2021 •
edited
Loading

  • due to the usage of tee the errors are not propagated correctly in
    TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
    fixes the issue by using PIPESTATUS env variable to obtain
    the pipelined command result

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

  • due to the usage of tee the errors are not propagated correctly in
    TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
    fixes the issue by using PIPESTATUS env variable to obtain
    the pipelined command result

Additional information

  • Affected modules and functionalities:
    • TL3_EfficientDet_convergence
    • TL3_YOLO_convergence
  • Key points relevant for the review:
    • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
6e0061a 
…ergence

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Sep 27, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3064270]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3064270]: BUILD PASSED

@klecki klecki self-assigned this Sep 27, 2021
@awolant awolant self-assigned this Sep 28, 2021
@JanuszL JanuszL merged commit 21a5189 into NVIDIA:main Sep 28, 2021
@JanuszL JanuszL deleted the fix_tl3_tests branch September 28, 2021 07:20
@jantonguirao jantonguirao added the important-fix Fixes an important issue in the software or development environment. label Sep 30, 2021
@JanuszL JanuszL removed the important-fix Fixes an important issue in the software or development environment. label Sep 30, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Oct 17, 2021
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
59d6c4e 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
9824171 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
c213826 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
4b14959 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
6de438e 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
e443bce 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
ec8e5dd 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
660b962 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
f941856 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
ac89c4f 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
c4002b6 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
7798d5f 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
69fd93a 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
6ee30a8 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
c841f25 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
58e9297 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@JanuszL @cyyever
Fix error reporting in TL3_EfficientDet_convergence and TL3_YOLO_conv…
5cc1de4 
…ergence (NVIDIA#3376)

- due to the usage of tee the errors are not propagated correctly in
  TL3_EfficientDet_convergence and TL3_YOLO_convergence. The PR
  fixes the issue by using PIPESTATUS env variable to obtain
  the pipelined command result

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@awolant awolant awolant approved these changes

Assignees

@klecki klecki

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JanuszL @dali-automaton @klecki @awolant @jantonguirao