Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable usage of sanitizers in tests #3377

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Enable usage of sanitizers in tests #3377

merged 3 commits into from
Oct 11, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 27, 2021 •
edited
Loading

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Additional information

  • Affected modules and functionalities:
    • Dockerfile.deps
    • tests
  • Key points relevant for the review:
    • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2325

@JanuszL JanuszL marked this pull request as draft September 27, 2021 16:14
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3065716]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3065716]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3068059]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3068059]: BUILD FAILED

@JanuszL JanuszL force-pushed the enable_asan_test branch 2 times, most recently from 562a46e to 6977964 Compare September 28, 2021 18:31
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3075168]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3075168]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3076590]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3076590]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3080914]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3080914]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3081905]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3081905]: BUILD FAILED

@JanuszL JanuszL force-pushed the enable_asan_test branch 2 times, most recently from b1a7706 to 9210f3b Compare October 1, 2021 20:41
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3102019]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3102041]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3102218]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3102218]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3114113]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3114113]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3117393]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3117393]: BUILD FAILED

jantonguirao
jantonguirao reviewed Oct 6, 2021
View reviewed changes
qa/test_template.sh Outdated
else
set -e
fi
enable_sanitizer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a personal preference, but I think it'd read better if the if's were around the calls to enable_sanitizer/disable_sanitizer/process_sanitizers_logs and not inside the functions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tools/test_bundled_libs.py
@@ -43,8 +43,10 @@ def main():
"librt.so.1",
"libstdc++.so.6",
"libgcc_s.so.1",
"libz.so.1",
"liblzma.so.5"
"libasan.so",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we always bundling this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. In contrary. We allow these libs that files inside the wheel depend on to be not bundled inside.
So even if we use sanitizers we won't bundle them.

@JanuszL
Review fixes
1926652 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3134436]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3134435]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3134436]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3134435]: BUILD PASSED

@JanuszL JanuszL merged commit b6af8a1 into NVIDIA:main Oct 11, 2021
@JanuszL JanuszL deleted the enable_asan_test branch October 11, 2021 16:16
cyyever pushed a commit to cyyever/DALI that referenced this pull request Oct 17, 2021
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
63b7296 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
bb2144e 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
0ef4947 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
a4b10e2 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
21eddd9 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
ea661f9 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
3468873 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
191487b 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
475562c 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
08f80e2 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
fba9275 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
19bbde6 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
cfab7a4 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
a37e50d 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
bea013e 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
5da34d1 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@JanuszL @cyyever
Enable usage of sanitizers in tests (NVIDIA#3377)
4d7e4b6 
* Enable usage of sanitizers in tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@stiepan stiepan stiepan approved these changes

Assignees

@jantonguirao jantonguirao

@stiepan stiepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanuszL @dali-automaton @jantonguirao @stiepan