Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable BUILD_LDMB by default #3406

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Enable BUILD_LDMB by default #3406

merged 1 commit into from
Oct 7, 2021

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Oct 6, 2021 •
edited
Loading

Signed-off-by: Joaquin Anton janton@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Just enabling BUILD_LDMB by default, as it is required by our most basic tests. Our build scripts set it to ON also.

Additional information

  • Affected modules and functionalities:
    Build system
  • Key points relevant for the review:
    N/A

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao
Enable BUILD_LDMB by default
177a54d 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3131189]: BUILD STARTED

@JanuszL JanuszL self-assigned this Oct 6, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3131189]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3131189]: BUILD PASSED

@jantonguirao jantonguirao merged commit eff2220 into NVIDIA:main Oct 7, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3138769]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3138769]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3139426]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3139426]: BUILD PASSED

cyyever pushed a commit to cyyever/DALI that referenced this pull request Oct 17, 2021
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
300db6b 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
9174ba6 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
fbd804e 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
59b9eac 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
624e14c 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
a660e95 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
f5167f0 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
291c9a9 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
58b2f57 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
92e56af 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
a9f7e80 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
cf796b6 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
a1cceb6 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
ff6d79d 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
d275e0b 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
b82b2b3 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@jantonguirao @cyyever
Enable BUILD_LDMB by default (NVIDIA#3406)
585c5a1 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@klecki klecki

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jantonguirao @dali-automaton @klecki @JanuszL