Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pointers with references for ShareData parameter #3408

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Replace pointers with references for ShareData parameter #3408

merged 1 commit into from
Oct 12, 2021

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Oct 6, 2021 •
edited
Loading

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Bring it to XXI century by using references.

Additional information

  • Affected modules and functionalities:
    ShareData in Tensor, TensorList and TensorVector.

  • Key points relevant for the review:
    N/A

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@klecki klecki marked this pull request as draft October 6, 2021 18:02
@klecki
Modernize ShareData API
fd7b424 
Bring it to XXI century by using references.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki klecki changed the title Modernize ShareData API Replace pointers with reference for ShareData parameter Oct 7, 2021
@klecki klecki changed the title Replace pointers with reference for ShareData parameter Replace pointers with references for ShareData parameter Oct 7, 2021
@klecki klecki marked this pull request as ready for review October 7, 2021 13:45
@klecki
Copy link
Contributor Author

klecki commented Oct 7, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3138946]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3138946]: BUILD PASSED

@jantonguirao jantonguirao assigned banasraf and unassigned banasraf Oct 7, 2021
@jantonguirao jantonguirao assigned szalpal and unassigned banasraf Oct 7, 2021
@klecki klecki merged commit 78b6ef2 into NVIDIA:main Oct 12, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Oct 17, 2021
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
f462d40 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
2387f41 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
a848236 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
ea80ee4 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
74bc893 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
6ef0823 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
1723596 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
d5ec050 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
839ca2a 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
4e5fcae 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
74bea00 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
85921b8 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
d5c1458 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
3c26ce8 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
854f959 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
9cbae1f 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@klecki @cyyever
Replace pointers with references for ShareData parameter (NVIDIA#3408)
c909f40 
Use the modern approach chosen in DALI coding guide
as opposed to pointers inherited from Google C++
style guide.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szalpal szalpal szalpal approved these changes

@mzient mzient mzient approved these changes

Assignees

@szalpal szalpal

@mzient mzient

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klecki @dali-automaton @szalpal @mzient @banasraf