Enable sanitizers in regular CI runs #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [3180966]: BUILD STARTED |
|
CI MESSAGE: [3180966]: BUILD PASSED |
|
CI MESSAGE: [3182601]: BUILD STARTED |
|
CI MESSAGE: [3182601]: BUILD FAILED |
|
CI MESSAGE: [3182601]: BUILD PASSED |
|
CI MESSAGE: [3188789]: BUILD STARTED |
|
CI MESSAGE: [3188789]: BUILD FAILED |
JanuszL
force-pushed
the
asan_runs
branch
2 times, most recently
from
7216f50
to
5a41464
Compare
|
CI MESSAGE: [3197785]: BUILD STARTED |
|
CI MESSAGE: [3197785]: BUILD FAILED |
JanuszL
force-pushed
the
asan_runs
branch
2 times, most recently
from
8c2710a
to
4508764
Compare
|
CI MESSAGE: [3213035]: BUILD STARTED |
|
CI MESSAGE: [3213035]: BUILD PASSED |
- adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
awolant
approved these changes
Oct 19, 2021
szalpal
approved these changes
Oct 19, 2021
mzient
reviewed
Oct 19, 2021
qa/test_template.sh
Outdated
| export ASAN_SYMBOLIZER_PATH=$(which llvm-symbolizer) | ||
| # avoid python false positives | ||
| export PYTHONMALLOC=malloc | ||
| # if something calls dlclose on a module that leaks and it happens before asan can extract symbols we get "unknown module" | ||
| # in the stack trace, to prevent this provide dlclose that does nothing | ||
| echo "int dlclose(void* a) { return 0; }" > /tmp/fake_dlclost.c && gcc -shared -o /tmp/libfakeclose.so /tmp/fake_dlclost.c |
There was a problem hiding this comment.
Suggested change
| echo "int dlclose(void* a) { return 0; }" > /tmp/fake_dlclost.c && gcc -shared -o /tmp/libfakeclose.so /tmp/fake_dlclost.c | |
| echo "int dlclose(void* a) { return 0; }" > /tmp/fake_dlclose.c && gcc -shared -o /tmp/libfakeclose.so /tmp/fake_dlclose.c |
There was a problem hiding this comment.
Q: Wouldn't fake_dlclose simply hide leaks in some cases? Or will it run regardless at process teardown?
Also, how does it affect module unloading order?
There was a problem hiding this comment.
This is a broader problem described and discussed google/sanitizers#89.
Wouldn't fake_dlclose simply hide leaks in some cases? Or will it run regardless at process teardown?
Yes, this trick would hide leaks of memory allocated in dlopen however in DALI we don't dlclose libs (except one), so the only leaks we would miss are from other libraries we won't fix anyway.
Also, how does it affect module unloading order?
I think there is no module unload in that case, the process is just closed and the whole memory is freed, But modules are not unloaded properly.
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [3223110]: BUILD STARTED |
|
CI MESSAGE: [3223110]: BUILD FAILED |
|
CI MESSAGE: [3226633]: BUILD STARTED |
|
CI MESSAGE: [3226633]: BUILD FAILED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [3231412]: BUILD STARTED |
|
CI MESSAGE: [3231412]: BUILD FAILED |
|
CI MESSAGE: [3231412]: BUILD PASSED |
awolant
approved these changes
Oct 21, 2021
00max09
pushed a commit
to szkarpinski/DALI
that referenced
this pull request
Dec 1, 2021
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> Signed-off-by: Maksymilian Grochowski <mg417883@students.mimuw.edu.pl>
00max09
pushed a commit
to szkarpinski/DALI
that referenced
this pull request
Dec 1, 2021
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> Signed-off-by: Maksymilian Grochowski <mg417883@students.mimuw.edu.pl>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Feb 21, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
* Enable sanitizers in regular CI runs - adds a suppression list that should disable all detected and not DALI originated errors - makes all leaks to fail the test job - turns off `fast_unwind_on_malloc` to make the stack trace more accurate (but slower) and allow more accurate suppressions, when the frame pointer is not preserved (python binary) - shortens tests TF based L0 test and excludes numpy_reader test when sanitizers are on Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and not DALI originated errors
fast_unwind_on_mallocto make the stack tracemore accurate (but slower) and allow more accurate suppressions,
when the frame pointer is not preserved (python binary)
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Description
What happened in this PR
and not DALI originated errors
fast_unwind_on_mallocto make the stack tracemore accurate (but slower) and allow more accurate suppressions,
when the frame pointer is not preserved (python binary)
Additional information
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2403