Fix documentation of CropMirrorNormalize dtype argument #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
stiepan
reviewed
Oct 21, 2021
| @@ -163,8 +163,7 @@ class CropMirrorNormalize : public Operator<Backend> { | |||
| void SetupCommonImpl(const workspace_t<Backend> &ws) { | |||
| const auto &input = ws.template InputRef<Backend>(0); | |||
| input_type_ = input.type(); | |||
| if (output_type_ == DALI_NO_TYPE) | |||
| output_type_ = input_type_; | |||
| assert(output_type_ != DALI_NO_TYPE); | |||
There was a problem hiding this comment.
Isn't it a breaking change? Or it is float by default?
There was a problem hiding this comment.
It is float by default, it is never DALI_NO_TYPE.
stiepan
approved these changes
Oct 21, 2021
awolant
approved these changes
Oct 21, 2021
|
!build |
|
CI MESSAGE: [3244213]: BUILD STARTED |
|
CI MESSAGE: [3244213]: BUILD PASSED |
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Feb 21, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Description
What happened in this PR
Update CropMirrorNormalize's dtype argument documentation. CropMirrorNormalize default dtype is FLOAT, not the input type.
Fixes #3437
Additional information
Fixed wrong description of dtype argument in CropMirrorNormalize
NA
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A