Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install boost/preprocessor headers #3443

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Install boost/preprocessor headers #3443

merged 1 commit into from
Oct 22, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Oct 22, 2021

Required for C++ API.

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Before this change, the users of prebuilt DALI had to supply their own copy of boost/preprocessor.
This PR ships boost/preprocessor headers with DALI installation.

Additional information

  • Affected modules and functionalities:
  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@mzient
Install boost/preprocessor headers - required for meaningful usage of…
8a084fe 
… C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@jantonguirao jantonguirao self-assigned this Oct 22, 2021
@jantonguirao jantonguirao self-requested a review October 22, 2021 14:08
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3244244]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3244244]: BUILD PASSED

@mzient mzient merged commit 0b9761e into NVIDIA:main Oct 22, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
9174d97 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
a8a7d5f 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
85f26e3 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
019e75c 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
70fb455 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
25c1064 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
ad5da2e 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
6e8d38b 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
71d2fac 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
d003c52 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
3d07f8f 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
6f98d62 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
ab4691b 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
874fba9 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
e890732 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@mzient @cyyever
Install boost/preprocessor headers (NVIDIA#3443)
26c6d78 
Install boost/preprocessor headers - required for meaningful usage of C++ API.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@jantonguirao jantonguirao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzient