Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency versions #3457

Merged
merged 10 commits into from
Nov 3, 2021
Merged

Update dependency versions #3457

merged 10 commits into from
Nov 3, 2021

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Oct 28, 2021 •
edited
Loading

Signed-off-by: szalpal mszolucha@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Updates for dependencies in DALI:
pybind 2.7.1 -> 2.8.1

Since FFmpeg v4.4.1, the security patches we had are no longer necessary - all the security fixes were applied. Therefore I'm changing the location of the source snapshot from NVIDIA's devzone to official github v4.4.1 snapshot.

Additional information

  • Affected modules and functionalities:

third_party, conda recipes and Readme

  • Key points relevant for the review:

N/A

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

JanuszL
JanuszL reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@JanuszL JanuszL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update https://github.com/NVIDIA/DALI/tree/main/conda/third_party/dali_opencv/recipe and https://github.com/NVIDIA/DALI/tree/main/conda/third_party/dali_ffmpeg/recipe

@jantonguirao jantonguirao self-assigned this Oct 28, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3288097]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3288099]: BUILD STARTED

@szalpal
pybind11 update to 2.8.1
45f9fd9 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
README update
c8da9c0 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
conda recipe update
ab994b7 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
update conda recipes
0707600 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
revoke proper README part
c4bac3e 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
erase DALI_DEPS_VERSION
8a50371 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3288228]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3288232]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3288232]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3288228]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3290808]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3290807]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3290807]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3291282]: BUILD STARTED

@szalpal szalpal changed the title Dependency update before the code freeze Update dependency versions Oct 29, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3290808]: BUILD PASSED

@szalpal szalpal marked this pull request as ready for review October 29, 2021 09:36
@JanuszL JanuszL self-assigned this Oct 29, 2021
JanuszL
JanuszL reviewed Oct 29, 2021
View reviewed changes
conda/third_party/dali_ffmpeg/recipe/meta.yaml Outdated
fn: FFmpeg-n4.4_v3.tar.gz
url: https://developer.download.nvidia.com/compute/redist/nvidia-dali/FFmpeg-n4.4_v3.tar.gz
sha256: 9b395c17e3c49979367e841a3526df7f2db38629f731b108dbb8a278855eccdd
fn: ffmpeg-n4.4.1.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stay with the one we host. We need to host it due to LGPL anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@szalpal
Revert to having the code in the devzone
2a4ee17 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
add sha256 checksum
9c07200 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3291282]: BUILD FAILED

jantonguirao
jantonguirao reviewed Oct 29, 2021
View reviewed changes
third_party/README.rst Outdated Show resolved Hide resolved
third_party/README.rst
.. |pybind11ver| replace:: 2.7.1
.. _pybind11ver: https://github.com/pybind/pybind11/releases/tag/v2.7.1
.. |pybind11ver| replace:: 2.8.1
.. _pybind11ver: https://github.com/pybind/pybind11/releases/tag/v2.8.1
.. |pybind11lic| replace:: BSD 3-Clause License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the RapidJSON update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@szalpal
Update DALI_DEPS_VERSION
de9aa84 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
rapidjson update
0082b00 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
Copy link
Member Author

szalpal commented Oct 29, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3293925]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3291282]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3293927]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3293996]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3293927]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3293996]: BUILD PASSED

@szalpal szalpal merged commit b8760f2 into main Nov 3, 2021
@JanuszL JanuszL deleted the ms-deps_update branch November 4, 2021 11:20
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
2a86adc 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
4707240 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
2a56deb 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
0f7c50b 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
b1d6446 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
681c60d 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
57f9db9 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
d751636 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
0d64287 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
9628112 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
b325b1c 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
8a890ee 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
c06606a 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
d924819 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
887b874 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@szalpal @cyyever
Update dependency versions (NVIDIA#3457)
9f70850 
* pybind11 update to 2.8.1
* README update
* conda recipe update
* Update DALI_DEPS_VERSION
* rapidjson update

Signed-off-by: szalpal <mszolucha@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@jantonguirao jantonguirao

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szalpal @dali-automaton @jantonguirao @JanuszL