Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NVIDIA Video Codec SDK - NVDECODE API #3458

Merged
merged 7 commits into from
Oct 29, 2021
Merged

Conversation

awolant
Copy link
Contributor

@awolant awolant commented Oct 28, 2021

Signed-off-by: Albert Wolant awolant@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Add NVIDIA Video Codec SDK - NVDECODE API and make it build within DALI

Additional information

  • Affected modules and functionalities:
- Copied NV Video Codec SDK to DALI
- added stubs of Driver functions used in the code
- added licence
- updated CMake files
  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Oct 28, 2021

!build

@stiepan stiepan self-assigned this Oct 28, 2021
@banasraf banasraf self-assigned this Oct 28, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3284355]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3284355]: BUILD FAILED

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Oct 28, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3284415]: BUILD STARTED

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Oct 28, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3284610]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3284610]: BUILD FAILED


NVIDIA Video Codec SDK headers

This copyright notice applies to this header file only:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line as it only introduces confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,1190 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is too much for this PR but I hope that in the next step you would remove the headers we currently have and adjust the code to use this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the plan, as long as it works without to much readjustments.

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3284610]: BUILD PASSED

@awolant awolant merged commit 0313810 into NVIDIA:main Oct 29, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
* Add NVIDIA Video Codec SDK - NVDECODE API

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants