Fix STRING_VEC default arguments presentation in docs #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [3332691]: BUILD STARTED |
|
CI MESSAGE: [3332691]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [3332733]: BUILD STARTED |
jantonguirao
approved these changes
Nov 4, 2021
ksztenderski
approved these changes
Nov 4, 2021
|
CI MESSAGE: [3332733]: BUILD PASSED |
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Feb 21, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
Adjust python_repr to handle vectors of elements, as it was currently dead code. We need to call repr on all strings as we do for single string argument. Add backticks around the default value in the generated docstring - it prevents string from interpreting glob expressions as markdown. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #3459
Description
What happened in this PR
Adjust python_repr to handle vectors of elements,
as it was currently dead code. We need to call repr
on all strings as we do for single string argument.
Add backticks around the default value in the generated
docstring - it prevents string from interpreting
glob expressions as markdown.
Additional information
Affected modules and functionalities:
Docs
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A