Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Keras version for TensorFlow 2.6 #3474

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Nov 8, 2021

  • the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
    so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

  • the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
    so this PR pins its version to 2.6

Additional information

  • Affected modules and functionalities:
    • setup_packages.py
  • Key points relevant for the review:
    • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3353963]: BUILD STARTED

@@ -438,7 +438,7 @@ def get_pyvers_name(self, url, cuda_version):
"110" : [
PckgVer("1.15.5", python_max_ver="3.7"),
"2.5.1",
PckgVer("2.6.0", dependencies=["tensorflow-estimator==2.6.0"]),
PckgVer("2.6.0", dependencies=["tensorflow-estimator==2.6.0", "keras==2.6.0"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that we don't have to pin it for other versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. I bet it is about TF itself not pinning the dependency version in the case of 2.6.x.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. I bet it is TF that doesn't pin its dependencies for 2.6.x.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3353963]: BUILD PASSED

@JanuszL JanuszL merged commit 73f11d0 into NVIDIA:main Nov 8, 2021
@JanuszL JanuszL deleted the pin_keras_version branch November 8, 2021 14:45
JanuszL added a commit that referenced this pull request Nov 8, 2021
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0,
  so this PR pins its version to 2.6

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants