-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Keras version for TensorFlow 2.6 #3474
Conversation
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
CI MESSAGE: [3353963]: BUILD STARTED |
@@ -438,7 +438,7 @@ def get_pyvers_name(self, url, cuda_version): | |||
"110" : [ | |||
PckgVer("1.15.5", python_max_ver="3.7"), | |||
"2.5.1", | |||
PckgVer("2.6.0", dependencies=["tensorflow-estimator==2.6.0"]), | |||
PckgVer("2.6.0", dependencies=["tensorflow-estimator==2.6.0", "keras==2.6.0"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that we don't have to pin it for other versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. I bet it is about TF itself not pinning the dependency version in the case of 2.6.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. I bet it is TF that doesn't pin its dependencies for 2.6.x.
CI MESSAGE: [3353963]: BUILD PASSED |
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
- the latest Keras (2.7.0) is incompatible with TensorFlow 2.6.0, so this PR pins its version to 2.6 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
so this PR pins its version to 2.6
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Description
What happened in this PR
so this PR pins its version to 2.6
Additional information
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A