Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unfold_outer_dim to common utilities. #3486

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Move unfold_outer_dim to common utilities. #3486

merged 1 commit into from
Nov 12, 2021

Conversation

prak-nv
Copy link
Contributor

@prak-nv prak-nv commented Nov 10, 2021 •
edited
Loading

Signed-off-by: Piotr Rak prak@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Follow up change to make TensorShapeList transformation generally available.
The original use case was transformation spliting FHWC tensor into list of frames (samples) to pass to the cuda kernel.

Additional information

  • Affected modules and functionalities:
  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 10, 2021

Still broken for dynamic lists when sample_dim() == 1. unfold_outer_dim_4test compiles for dynamic lists.

@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 10, 2021

Was just flakiness around initialization of TensorListShape<-1>, didn't look into it.

@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 10, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3374504]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3374504]: BUILD PASSED

@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 11, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3376679]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3376679]: BUILD PASSED

@prak-nv prak-nv force-pushed the unfold_outer_dim branch 2 times, most recently from 4401ff4 to e2c6f18 Compare November 12, 2021 08:57
@prak-nv prak-nv changed the title WIP: Move unfold_outer_dim to common utilities. Move unfold_outer_dim to common utilities. Nov 12, 2021
@prak-nv prak-nv marked this pull request as ready for review November 12, 2021 08:59
@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 12, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3385456]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Nov 12, 2021
@mzient mzient self-assigned this Nov 12, 2021
jantonguirao
jantonguirao reviewed Nov 12, 2021
View reviewed changes
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
mzient
mzient reviewed Nov 12, 2021
View reviewed changes
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
include/dali/core/tensor_shape.h Outdated Show resolved Hide resolved
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3385456]: BUILD PASSED

@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 12, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3386518]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3386518]: BUILD FAILED

jantonguirao
jantonguirao approved these changes Nov 12, 2021
View reviewed changes
dali/core/tensor_shape_test.cc Outdated Show resolved Hide resolved
dali/core/tensor_shape_test.cc Outdated Show resolved Hide resolved
@prak-nv
Move unfold_outer_dim to common utilities.
f9b7ede 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
@prak-nv
Copy link
Contributor Author

prak-nv commented Nov 12, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3386686]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3386686]: BUILD PASSED

@prak-nv prak-nv merged commit aeae329 into NVIDIA:main Nov 12, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
6903a31 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
d40d29d 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
b772ff3 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
4bc5dba 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
4e90f2a 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
d7e7c29 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
fd53ca3 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
4066318 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
dedf43c 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
774dc18 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
d25d278 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
ff1b1db 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
fa99c40 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
e0bddfe 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
d34a668 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@prak-nv @cyyever
Move unfold_outer_dim to common utilities. (NVIDIA#3486)
5624cab 
Also extends to support DynamicDimentions.

Signed-off-by: Piotr Rak <prak@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@mzient mzient mzient approved these changes

@klecki klecki Awaiting requested review from klecki

@szalpal szalpal Awaiting requested review from szalpal

Assignees

@jantonguirao jantonguirao

@mzient mzient

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prak-nv @dali-automaton @jantonguirao @mzient