Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Copy GPU benchmark #3517

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Add Copy GPU benchmark #3517

merged 3 commits into from
Nov 23, 2021

Conversation

szkarpinski
Copy link
Collaborator

@szkarpinski szkarpinski commented Nov 19, 2021 •
edited by JanuszL
Loading

Signed-off-by: Szymon Karpiński hugo@staszic.waw.pl

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

This PR adds a benchmark for GPU version of the Copy operator, which runs this operator on various batch sizes and image sizes.

Additional information

  • Affected modules and functionalities: adds a single benchmark file dali/benchmarks/copy_bench.cc together with a CMakeLists entry.

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

JanuszL
JanuszL reviewed Nov 19, 2021
View reviewed changes
dali/benchmark/copy_bench.cc Outdated
@@ -0,0 +1,49 @@
// Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to copy-past Nvidia copyright - you can add your own name there.

@JanuszL JanuszL self-assigned this Nov 19, 2021
@szkarpinski
Add Copy GPU benchmark
49f5973 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@szkarpinski
Fix copyright comment
d664f08 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@szkarpinski
Fix typo in copyright comment
c028a62 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@szkarpinski szkarpinski marked this pull request as ready for review November 22, 2021 11:38
@JanuszL
Copy link
Contributor

JanuszL commented Nov 23, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3460086]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3460086]: BUILD PASSED

@JanuszL JanuszL merged commit 9bb29e7 into NVIDIA:main Nov 23, 2021
00max09 pushed a commit to szkarpinski/DALI that referenced this pull request Dec 1, 2021
@szkarpinski @00max09
Add Copy GPU benchmark (NVIDIA#3517)
9459e02 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
Signed-off-by: Maksymilian Grochowski <mg417883@students.mimuw.edu.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
3b31f7b 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
00c8158 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
162a610 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
7f651d3 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
ab10e97 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
d0fcca6 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
bcdd31f 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
2f268dc 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
7d27860 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
5b84fdb 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
0338bd1 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
baf98dd 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
4ccd9d9 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
248308d 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
cca33bd 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@szkarpinski @cyyever
Add Copy GPU benchmark (NVIDIA#3517)
5da540a 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiepan stiepan stiepan approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@stiepan stiepan

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szkarpinski @JanuszL @dali-automaton @stiepan