-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues found during static analysis #3524
Conversation
Signed-off-by: Joaquin Anton <janton@nvidia.com>
ff1cd9c
to
36acc0a
Compare
CI MESSAGE: [3458867]: BUILD FAILED |
CI MESSAGE: [3458885]: BUILD STARTED |
CI MESSAGE: [3458898]: BUILD STARTED |
CI MESSAGE: [3458885]: BUILD FAILED |
CI MESSAGE: [3458898]: BUILD FAILED |
CI MESSAGE: [3460635]: BUILD STARTED |
CI MESSAGE: [3460635]: BUILD PASSED |
int f_dim = layout.find('F'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are asserts for every value here, why no assert for f_dim
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we allow it to be -1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See lines 97-98
Signed-off-by: Joaquin Anton <janton@nvidia.com> Signed-off-by: Maksymilian Grochowski <mg417883@students.mimuw.edu.pl>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton janton@nvidia.com
Description
What happened in this PR
Fixing minor issues found during static analysis
Additional information
Various small fixes
NA
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2472