Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bundle-wheel.sh more configurable #3539

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Make bundle-wheel.sh more configurable #3539

merged 3 commits into from
Nov 30, 2021

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Nov 29, 2021

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.

Additional information

  • Affected modules and functionalities:
  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@klecki
Make bundle-wheel.sh more configurable
dab7f45 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Nov 29, 2021

!build

@JanuszL JanuszL self-assigned this Nov 29, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3491807]: BUILD STARTED

@klecki
More options passthrough
3f12b9f 
I don't see any useful way of adding WHL_OUTDIR to build.sh

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Should be enough
055fbdb 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Nov 29, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3491807]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3491807]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3492435]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3492435]: BUILD PASSED

@jantonguirao jantonguirao self-assigned this Nov 30, 2021
@klecki klecki merged commit b38135b into NVIDIA:main Nov 30, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
06c14c9 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
a3e5313 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
ae39c98 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
7d35979 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
daae79f 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
0b9ddb6 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
1d33849 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
b38b4be 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
b3da546 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
20e80cb 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
a2ad616 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
f870585 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
de2d9df 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
f440ea1 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
a17b75c 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@klecki @cyyever
Make bundle-wheel.sh more configurable (NVIDIA#3539)
bb45944 
Allow to configure output path for bundle wheel script.
Add option to not compress the output wheel.
Those changes should allow for easier and faster development work.
Removing compression saves about a minute of wheel packaging.
Allow to turn off the compression in build.sh and docker.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@jantonguirao jantonguirao jantonguirao approved these changes

Assignees

@jantonguirao jantonguirao

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klecki @dali-automaton @jantonguirao @JanuszL