Fix data race when copying outputs in TF plugin #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
JanuszL
approved these changes
Nov 30, 2021
|
CI MESSAGE: [3500935]: BUILD STARTED |
|
!build |
|
CI MESSAGE: [3501189]: BUILD STARTED |
|
CI MESSAGE: [3501189]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [3506033]: BUILD STARTED |
stiepan
approved these changes
Dec 1, 2021
|
CI MESSAGE: [3506033]: BUILD FAILED |
|
CI MESSAGE: [3506033]: BUILD PASSED |
klecki
added
the
important-fix
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jan 23, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Feb 21, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
DALI TF Plugin was copying the outputs on TF's stream and was not synchronizing with the copy. In some cases we can overtake the copy with DALI iteration and overwrite the buffers before they are actually copied. Add a flag to synchronize with the stream after last copy is scheduled so we synchronize only once. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What happened in this PR
DALI TF Plugin was copying the outputs on
TF's stream and was not synchronizing with
the copy.
In some cases we can overtake the copy
with DALI iteration and overwrite the buffers
before they are actually copied.
Add a flag to synchronize with the stream after
last copy is scheduled so we synchronize only
once.
Additional information
Affected modules and functionalities:
TF plugin
Key points relevant for the review:
Check if sync is enough
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2483