Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments about scale argument #3581

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add comments about scale argument #3581

merged 1 commit into from
Dec 20, 2021

Conversation

awolant
Copy link
Contributor

@awolant awolant commented Dec 17, 2021 •
edited by jantonguirao
Loading

Signed-off-by: Albert Wolant awolant@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Improve comments in Box Encoder

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@awolant
Add comments about scale argument
eec3dcc 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Dec 17, 2021

!build

@awolant awolant mentioned this pull request Dec 17, 2021
Closed
@JanuszL JanuszL self-assigned this Dec 17, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3613585]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Dec 17, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3613585]: BUILD PASSED

@awolant awolant merged commit 283a792 into NVIDIA:main Dec 20, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
9415291 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
6849f12 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
332e9f4 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
1d813c1 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
fd8198d 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
709ee97 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
76319eb 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
c49e35c 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
20c8540 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
3231837 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
56cf868 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
6e1b91c 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
c3bc994 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
8b95c2d 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
b07cd61 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@awolant @cyyever
Add comments about scale argument (NVIDIA#3581)
eea9166 
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@jantonguirao jantonguirao

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awolant @dali-automaton @jantonguirao @JanuszL