Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JPEG distortion GPU quality argument handling for sequences #3590

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix JPEG distortion GPU quality argument handling for sequences #3590

merged 1 commit into from
Dec 21, 2021

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Fixes a bug in JPEG distortion GPU operator, in the distribution of quality argument to all frames in a sequence.

Additional information

  • Affected modules and functionalities:

JPEG distortion operator

  • Key points relevant for the review:

New test, changes in the op

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao jantonguirao added the important-fix Fixes an important issue in the software or development environment. label Dec 21, 2021
@jantonguirao
Fix JPEG distortion GPU quality argument handling for sequences
05ac736 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@klecki klecki self-assigned this Dec 21, 2021
@banasraf banasraf self-assigned this Dec 21, 2021
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3635166]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3635166]: BUILD PASSED

@jantonguirao jantonguirao merged commit fac77c1 into NVIDIA:main Dec 21, 2021
JanuszL pushed a commit that referenced this pull request Dec 23, 2021
@jantonguirao @JanuszL
Fix JPEG distortion GPU quality argument handling for sequences (#3590)
b815571 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
306941a 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
277ef37 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
fcca902 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
d17e97a 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
b3ca1f0 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
664afd3 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
63f5411 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
ed5c1f5 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
bdfa371 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
e180662 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
fa686f8 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
abf90e3 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
112c0a6 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
7c11672 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
fff6f69 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@jantonguirao @cyyever
Fix JPEG distortion GPU quality argument handling for sequences (NVID…
bfaaffe 
…IA#3590)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@banasraf banasraf banasraf approved these changes

Assignees

@klecki klecki

@banasraf banasraf

Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jantonguirao @dali-automaton @klecki @banasraf