Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorList shape #3591

Merged
merged 5 commits into from
Jan 11, 2022
Merged

TensorList shape #3591

merged 5 commits into from
Jan 11, 2022

Conversation

ksztenderski
Copy link
Contributor

@ksztenderski ksztenderski commented Dec 21, 2021 •
edited
Loading

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Adds shape method to TensorListCPU/GPU and DataNodeDebug.

Additional information

  • Affected modules and functionalities:

TensorListCPU/GPU
DataNodeDebug

  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@ksztenderski
Add shape method to TL and DataNodeDebug
0f833e9 
Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3635530]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3635530]: BUILD PASSED

klecki
klecki reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@klecki klecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, please add a dedicated test for TensorList.

Also as a bonus question: can we impact the type of the return value shown in the docstring anyhow?

Screenshot 2021-12-22 at 18-33-35 Types — NVIDIA DALI 1 10 0dev documentation
I wonder if we can make it -> list of tuples or list[tuple] (or however it is according to Python type annotations). (Just curious if it's possible, it would be nice to have but it's not a blocker).

dali/python/backend_impl.cc
@@ -693,6 +702,10 @@ void ExposeTensorList(py::module &m) {
.def("layout", [](TensorList<CPUBackend> &t) {
return t.GetLayout().str();
})
.def("shape", &py_shape_list<CPUBackend>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this in the test_backend_impl.py or similar? Produce a TensorList of known shape and check if it returns it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, managed to change the type of the return value in the docstring as well.

Screenshot 2022-01-04 110730

@ksztenderski
TensorList shape test
4bc9590 
Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3669100]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3669100]: BUILD FAILED

@ksztenderski
TensorListGPU shape test
6449746 
Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3672611]: BUILD STARTED

@ksztenderski
list of tuple return value of TL shape in docstring
e3280b4 
Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3672877]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3672877]: BUILD PASSED

@ksztenderski
TL shape test TensorListCPU construction change
3ccc5ba 
Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3673161]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3673161]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3673161]: BUILD PASSED

@ksztenderski ksztenderski merged commit a3965c7 into NVIDIA:main Jan 11, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
3f25c58 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
322eafd 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
f472b65 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
63bcebd 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
4f3fd07 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
e253260 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
4b88a8a 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
8326a02 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
ff2c117 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
953403f 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
b3589c3 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
ce4767d 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
0302da4 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
6e42277 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
6b4804a 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@ksztenderski @cyyever
TensorList shape (NVIDIA#3591)
7d8bed2 
Add shape to TensorListCPU/GPU and DataNodeDebug

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@stiepan stiepan stiepan approved these changes

Assignees

@klecki klecki

@stiepan stiepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksztenderski @dali-automaton @klecki @stiepan