Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same device for debug mode test and baseline #3594

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Use the same device for debug mode test and baseline #3594

merged 2 commits into from
Dec 22, 2021

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Dec 22, 2021 •
edited
Loading

Signed-off-by: Krzysztof Lecki klecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Random resized crop was invoked always on CPU in baseline code,
but on GPU for some debug mode tests leading to inaccuracies.

The reduced epsilon was removed.

Additional information

  • Affected modules and functionalities:
    Debug mode tests

  • Key points relevant for the review:
    N/a

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@klecki
Use the same device for debug mode test and baseline
74ef1aa 
Random resized crop was invoked always on CPU in baseline code,
but on GPU for some debug mode tests.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Add transfer, remove eps
cba021f 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3640946]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Dec 22, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3640946]: BUILD PASSED

@klecki klecki merged commit a61616c into NVIDIA:main Dec 22, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
3e70918 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
a868cc2 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
2403fca 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
ce31b5c 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
d15fa25 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
17c8aae 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
951db20 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
7b86cd6 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
6845c63 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
2105de8 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
5a2d594 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
65d5e7a 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
7f929f8 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
8599467 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
2b187ec 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@klecki @cyyever
Use the same device for debug mode test and baseline (NVIDIA#3594)
73b7ef5 
Random resized crop was always invoked on CPU
in the baseline code, but on GPU for some 
of the debug mode tests, leading to inaccuracies.
Adjust the device used for operator in the test to match.

The reduced epsilon for GPU was removed
as it is no longer needed.

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@stiepan stiepan stiepan approved these changes

Assignees

@jantonguirao jantonguirao

@stiepan stiepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klecki @dali-automaton @jantonguirao @stiepan