Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of scalar argument in slice operator #3596

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix handling of scalar argument in slice operator #3596

merged 1 commit into from
Dec 23, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Dec 23, 2021

  • when a scalar argument is provided to slice it tries to obtain
    its shape which is empty what leads to a crash. Fixes this problem
    by providing a proper guard

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

  • when a scalar argument is provided to slice it tries to obtain
    its shape which is empty what leads to a crash. Fixes this problem
    by providing a proper guard

Additional information

  • Affected modules and functionalities:
    • slice arg
  • Key points relevant for the review:
    • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2529

@JanuszL
Fix handling of scalar argument in slice operator
65e2a3e 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3643711]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3643711]: BUILD PASSED

@jantonguirao jantonguirao self-assigned this Dec 23, 2021
@jantonguirao jantonguirao added the important-fix Fixes an important issue in the software or development environment. label Dec 23, 2021
@awolant awolant self-assigned this Dec 23, 2021
@JanuszL JanuszL merged commit 06f611e into NVIDIA:main Dec 23, 2021
@JanuszL JanuszL deleted the fix_slice_args branch December 23, 2021 10:25
JanuszL added a commit that referenced this pull request Dec 23, 2021
@JanuszL
Fix handling of scalar argument in slice operator (#3596)
7f2c492 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
90a89c6 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
94efa48 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
bc5d97f 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
0a9ceba 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
5e3fe50 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
2351f58 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
b218c84 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
35c9814 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
130da13 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
d86a201 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
cca999a 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
c8722d7 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
b510831 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
90b5457 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
4913fcf 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@JanuszL @cyyever
Fix handling of scalar argument in slice operator (NVIDIA#3596)
640a6a9 
- when a scalar argument is provided to slice it tries to obtain
  its shape which is empty what leads to a crash. Fixes this problem
  by providing a proper guard

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@awolant awolant awolant approved these changes

Assignees

@jantonguirao jantonguirao

@awolant awolant

Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanuszL @dali-automaton @jantonguirao @awolant