Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TensorList constructor from list of tensors. #3626

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fix TensorList constructor from list of tensors. #3626

merged 2 commits into from
Jan 18, 2022

Conversation

ksztenderski
Copy link
Contributor

@ksztenderski ksztenderski commented Jan 18, 2022 •
edited
Loading

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

It fixes a bug with TensorList constructor from list of tensors.
Fixed issues (raising exceptions), when constructing TensorList from:

  • an empty list
  • different backend tensors
  • different dtype tensors

Additional information

  • Affected modules and functionalities:

TensorList constructor from list of Tensors

  • Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@ksztenderski
Fix TensorList from list of tensors.
e514a6d 
Fixed issues:
- from empty list
- different backend tensors
- different dtype tensors

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3776507]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3776531]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3776507]: BUILD FAILED

prak-nv
prak-nv reviewed Jan 18, 2022
View reviewed changes
dali/python/backend_impl.cc Outdated

tv[i].ShareData(t);
} catch (const py::type_error &e) {
throw e;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, just throw; would have rethrow e.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ksztenderski
Simplify throw
50a74a4 
Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3776507]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3776531]: BUILD PASSED

@ksztenderski
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3777189]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3777189]: BUILD PASSED

@ksztenderski ksztenderski merged commit e63cab0 into NVIDIA:main Jan 18, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
2b98f82 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
c111bf3 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
bf4b7f0 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
4a05e36 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
7f18597 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
6c7e069 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
2a8e44c 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
1df9153 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
bcdfe6e 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
8b05961 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
71201ed 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
ff5dbbb 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
ed62ab4 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
9b3aff2 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
@szalpal szalpal added the important-fix Fixes an important issue in the software or development environment. label Mar 1, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
50140ef 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@ksztenderski @cyyever
Fix TensorList constructor from list of tensors. (NVIDIA#3626)
5de5e23 
Fixed issues (raising exceptions), when constructing TensorList from an empty list,
different backend tensors or different dtype tensors.

Signed-off-by: ksztenderski <ksztenderski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@prak-nv prak-nv prak-nv approved these changes

Assignees

@klecki klecki

@prak-nv prak-nv

Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ksztenderski @dali-automaton @klecki @prak-nv @szalpal