Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates FindNVJPEG.cmake #3643

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Updates FindNVJPEG.cmake #3643

merged 1 commit into from
Jan 27, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jan 25, 2022

  • NVJPEG header defines now the MAJOR, MINOR, and PATCH version
    in the header for FindNVJPEG doesn't have to parse the binary file
    looking for the toolkit used during the build

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • NVJPEG header defines now the MAJOR, MINOR, and PATCH version
    in the header for FindNVJPEG doesn't have to parse the binary file
    looking for the toolkit used during the build

Additional information:

Affected modules and functionalities:

  • FindNVJPEG.cmake

Key points relevant for the review:

  • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- NVJPEG header defines now the MAJOR, MINOR, and PATCH version
  in the header for FindNVJPEG doesn't have to parse the binary file
  looking for the toolkit used during the build

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Jan 25, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3823986]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3823986]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3840052]: BUILD STARTED

@JanuszL JanuszL merged commit bcfd605 into NVIDIA:main Jan 27, 2022
@JanuszL JanuszL deleted the update_findnvjpeg branch January 27, 2022 18:07
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
- NVJPEG header defines now the MAJOR, MINOR, and PATCH version
  in the header for FindNVJPEG doesn't have to parse the binary file
  looking for the toolkit used during the build

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
- NVJPEG header defines now the MAJOR, MINOR, and PATCH version
  in the header for FindNVJPEG doesn't have to parse the binary file
  looking for the toolkit used during the build

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
- NVJPEG header defines now the MAJOR, MINOR, and PATCH version
  in the header for FindNVJPEG doesn't have to parse the binary file
  looking for the toolkit used during the build

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants