Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax test tolerance in DisplacementTest/Sphere and Water #3649

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jan 28, 2022

  • increases the epsilon to 0.005 to make the DisplacementTest
    more failure proof

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • increases the epsilon to 0.005 to make the DisplacementTest
    more failure proof

Additional information:

Affected modules and functionalities:

  • DisplacementTest

Key points relevant for the review:

  • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- increases the epsilon to 0.005 to make the DisplacementTest
  more failure proof

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Jan 28, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3846956]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Jan 28, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3846956]: BUILD PASSED

@JanuszL JanuszL merged commit 1315e53 into NVIDIA:main Jan 28, 2022
@JanuszL JanuszL deleted the improve_disp_Test branch January 28, 2022 14:38
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
- increases the epsilon to 0.005 to make the DisplacementTest
  more failure proof

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
- increases the epsilon to 0.005 to make the DisplacementTest
  more failure proof

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
- increases the epsilon to 0.005 to make the DisplacementTest
  more failure proof

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants