Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in tensor_shape.h #3695

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

szkarpinski
Copy link
Collaborator

@szkarpinski szkarpinski commented Feb 21, 2022

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

When reading tensor_shape.h I found a few typos (in comments and error message - nothing serious), so I'm fixing them in this PR.

Additional information:

Key points relevant for the review:

I strongly believe that TensorShapeList in unfold_outer_dim (description and error message) was meant to be TensorListShape as no such thing as TensorShapeList is mentioned elsewhere. I'd be grateful for confirming that.

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@szalpal
Copy link
Member

szalpal commented Feb 22, 2022

!build

1 similar comment
@szalpal
Copy link
Member

szalpal commented Feb 22, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4021816]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4021816]: BUILD PASSED

@szalpal szalpal merged commit 789a433 into NVIDIA:main Feb 24, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants