Add per-frame operator #3723
Add per-frame operator #3723
Conversation
|
!build |
dali/pipeline/operator/op_schema.h
Outdated
| DLL_PUBLIC inline OpSchema& SupportPerFrameArgs() { | ||
| support_per_frame_ = true; | ||
| return *this; | ||
| } |
There was a problem hiding this comment.
I think what we might need fine grain control of which exact argument makes sense to be provided per frame.
There was a problem hiding this comment.
This should be inferred from argument descriptions.
There was a problem hiding this comment.
Interesting idea; but is such info needed at all if we decided to mark arguments and mention per-frame support in their descriptions?
| @@ -130,6 +130,8 @@ def _get_kwargs(schema): | |||
| default_value = ast.literal_eval(default_value_string) | |||
| type_name += ", default = `{}`".format(_default_converter(dtype, default_value)) | |||
| doc += schema.GetArgumentDox(arg) | |||
| if schema.ArgSupportsPerFrameInput(arg): | |||
There was a problem hiding this comment.
This requires the other PR to work, doesn't it?
There was a problem hiding this comment.
Yeah, it needs to be rebased.
There was a problem hiding this comment.
Just wanted to have it ready here so that it could be read, reviewed and discussed if needed.
|
Unless something significantly changes, I can review this instead of @prak-nv, but for now it is already approved. Add me if you need me. |
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
… sequneces need to have matching shapes Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
|
!build |
|
CI MESSAGE: [4455657]: BUILD STARTED |
|
CI MESSAGE: [4455657]: BUILD PASSED |
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
|
!build |
|
CI MESSAGE: [4462185]: BUILD STARTED |
|
CI MESSAGE: [4462185]: BUILD FAILED |
|
CI MESSAGE: [4462185]: BUILD PASSED |
* Add per-frame operator * Use per-frame operator in sequence operator tests * Link to per-frame operator docs from arguments supporting per-frame input Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
* Add per-frame operator * Use per-frame operator in sequence operator tests * Link to per-frame operator docs from arguments supporting per-frame input Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Category:
New feature (non-breaking change which adds functionality)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
The operator is CPU only for the same reason the fn.transofrms are - it is supposed to be used only on arguments to other operators.
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: PERFR.01-PERFR.05
JIRA TASK: DALI-2566